Crash with patched svn rev 614

[AsYlum]

Hello i've compiled latest sources revision - 614 and added voicer packet flood patch. We're experiencing random crashes from time to time. Looks like it gives the same stacktrace on every crash.

Here it is with gdb info on unstripped 32bit binary: http://pastebin.com/NR93f4H8

One extra line which was added is in uomod.cpp around line 3798 Log("MoveItemToCont...: %s \n", item->serial); but it was crashing before adding it.

[Voicer]

i am no longer supporting our polish shard but already knows that the stability of pol099 (rev 600+) is very small, server crashes after several hours/day with high online count.

My patch is not working well with enhanced clients (it treats them like hack attack ) but apart from that, we saw the same crashes before patch and after patch.

[RusseL]

i use rev 572 as base and then i've added the following things:

+ SpeechTokens bugfix (pol/uoscrobj.cpp) from rev573
+ Poison healthbar packet fix (pol/mobile/charactr.cpp) from rev591
+ rev597 fixes
+ typo from rev598 (pol/uolisten.cpp)
+ rev613 fixed a crash under linux (pol/login.cpp)
+ patch from forum ( http://forums.polserver.com/viewtopic.p ... 72&p=19492 )

35days without any crash for now (linux 32bit)

i don't kile turley's "cleanups"...

[xeon]

MMm guys you're making me scared... I'm starting a build up of POL099, I really need to choose the right SVN version? The latest SVN version is not stable?
I ask because, after I've rebuilded the shard on 099, it will not be touched for a loooooooooong time

[Yukiko]

Sorry for deviating from the topic but I have to ask a couple questions. RusseL, how difficult was it to piece those patches together? WHat steps did you take to do it? Maybe you could post a guide explaining how to extract individual revisions from the repository for those of us who are new to using SVN. I am trying to rework my scripts to make them compatible with the latest Core and UO clients so, like xeon, I want to have a stable version.

Thanks.

[RusseL]

Ah, that's easy, you can see here what was changed in which revision http://polserver.svn.sourceforge.net/vi ... vision=573
Then take what you need, and update your sources manually.

For example (on rev573) speech tokens bug fix could be only in uoscrobj.cpp, everything else are the speedup things.
Press at "Text Modified", and the lowest fix does something with speechtokens. Bingo

You can see there Revision Log and many other interresting things.
If you want i can upload my binary, it is stable for me now, but no warranty...

[Yukiko]

RusseL, thanks for the information. I'll check it out. If you want to upload your binary I would appreciate it. Hopefully the problems with crashes will get fixed soon so we can have all the revisions since 573.

[RusseL]

here

[RusseL]

New build, if anyone need it

Revision 572
+ SpeechTokens bugfix (pol/uoscrobj.cpp) from rev573
+ Poison healthbar packet fix (pol/mobile/charactr.cpp) from rev591
+ rev597 fixes
+ typo from rev598 (pol/uolisten.cpp)
+ rev613 fixed a crash under linux (pol/login.cpp)
+ patch from forum ( http://forums.polserver.com/viewtopic.p ... 72&p=19492 )
+ Added SystemHook "WarmodeChange" rev592
+ linux fix rev604
+ Changed UO:ListMobilesNearLocationEx rev607
+ typo rev610
+ Changed STAIR_MULTIID_MAX rev612
+ Items get their facing from tiledata rev614
+ fixed possible speechtoken crash rev616
+ Added Syshook CanTrade rev617
+ Fixed pol crash using Razor and scripted merchant handlers