Characters&NPC Animations Core Bug?

Archive of posts related to former distro versions. Be aware that posts here do not refer to the current distro and may not work.

Moderators: POL Developer, Distro Developer

Locked
tomtommy
New User
Posts: 27
Joined: Tue Oct 15, 2013 1:33 am

Characters&NPC Animations Core Bug?

Post by tomtommy »

I think there's something wrong with the last core revision, it seems that the character's and npc's animations are not visible anymore ( PerformAction function ).
kevin
POL Developer
Posts: 53
Joined: Wed Sep 29, 2010 3:47 pm
Contact:

Re: Characters&NPC Animations Core Bug?

Post by kevin »

Can you provide a use case? My actions are performing fine. Have you modified your mul files at all?

Code: Select all

use uo;

include "include/client";

program prg(who)
	PerformAction(who,ANIM_CAST_AREA);
endprogram
This does the proper action in the client. Can also see the packet sent if you turn on packet logging for your character (via .startlog):

Code: Select all

Server -> Client: 0x6E, 14 bytes
0000 6e 00 00 3f 2b 00 11 00  05 00 01 00 00 01         n..?+... ........
tomtommy
New User
Posts: 27
Joined: Tue Oct 15, 2013 1:33 am

Re: Characters&NPC Animations Core Bug?

Post by tomtommy »

kevin wrote:Can you provide a use case? My actions are performing fine. Have you modified your mul files at all?

Code: Select all

use uo;

include "include/client";

program prg(who)
	PerformAction(who,ANIM_CAST_AREA);
endprogram
This does the proper action in the client. Can also see the packet sent if you turn on packet logging for your character (via .startlog):

Code: Select all

Server -> Client: 0x6E, 14 bytes
0000 6e 00 00 3f 2b 00 11 00  05 00 01 00 00 01         n..?+... ........
Already tried to check PerformAction by command, but no actions are visible, also NPC attack animations ecc. There where no problems about animations before this commit: "fixed animation on mount if animxlate cfg is not complete for this graphic" ( 15 days ago ). I've recompiled with last pol-core fixes and now something is going wrong.
Turley
POL Developer
Posts: 670
Joined: Sun Feb 05, 2006 4:45 am

Re: Characters&NPC Animations Core Bug?

Post by Turley »

Can you give me some more detailed informations? On my shard it works without problems after the mentioned commit in the usual way, (the new feature is currently undocumented since it needs more testing)
But I'm currently on vacation thus it will take a while since i can answer or look deeper into it.
tomtommy
New User
Posts: 27
Joined: Tue Oct 15, 2013 1:33 am

Re: Characters&NPC Animations Core Bug?

Post by tomtommy »

Code: Select all

Client -> Server: 0xAD, 32 bytes
0000ad 00 20 00 00 34 00 03  49 54 41 00 00 2e 00 61   .. ..4.. ITA....a
001000 63 00 74 00 69 00 6f  00 6e 00 20 00 31 00 00   .c.t.i.o .n. .1..

Server -> Client: 0x1C, 84 bytes
00001c 00 54 01 01 01 01 01  01 00 03 e8 00 03 53 79   ..T..... ......Sy
001073 74 65 6d 00 00 00 00  00 00 00 00 00 00 00 00   stem.... ........
002000 00 00 00 00 00 00 00  00 00 00 00 57 68 6f 6d   ........ ....Whom
003020 64 6f 20 79 6f 75 20  77 61 6e 74 20 74 6f 20    do you  want to 
004070 65 72 66 6f 72 6d 20  74 68 65 20 61 63 74 69   perform  the acti
00506f 6e 3f 00                                        on?..... ........

Server -> Client: 0x6C, 19 bytes
00006c 00 00 00 00 07 00 00  00 00 00 00 00 00 00 00   l....... ........
001000 00 00                                           ........ ........

Client -> Server: 0x6C, 19 bytes
00006c 00 00 00 00 07 00 00  00 00 02 15 dc 04 f4 00   l....... ........
001000 01 90                                           ........ ........
Turley
POL Developer
Posts: 670
Joined: Sun Feb 05, 2006 4:45 am

Re: Characters&NPC Animations Core Bug?

Post by Turley »

So your pkt log is to short or you don't get a animation sent.
With more detailed I mean which client version, do you have pkt hooks etc..
tomtommy
New User
Posts: 27
Joined: Tue Oct 15, 2013 1:33 am

Re: Characters&NPC Animations Core Bug?

Post by tomtommy »

My client version is 7.0.10.3. Sorry for my little help but I'm quite noob about packets.

@Kevin: my MUL files are ok, I hadn't any problem with the previous core-rev of 2 weeks ago.

This is log file with an example of magic cast performed by character without visible animation.

Packet 0x6E isn't logged.

Code: Select all

[09/18 17:23:05] Logfile opened.
Server -> Client: 0x1C, 65 bytes
00001c 00 41 01 01 01 01 01  01 00 03 b2 00 03 53 79   ..A..... ......Sy
001073 74 65 6d 00 00 00 00  00 00 00 00 00 00 00 00   stem.... ........
002000 00 00 00 00 00 00 00  00 00 00 00 49 2f 4f 20   ........ ....I/O 
00306c 6f 67 20 66 69 6c 65  20 6f 70 65 6e 65 64 2e   log file  opened.
004000                                                 ........ ........

Client -> Server: 0x12, 6 bytes
000012 00 06 56 36 00                                  ...V6... ........

Server -> Client: 0x1C, 51 bytes
00001c 00 33 00 00 00 02 01  90 00 03 e8 00 03 74 6f   ..3..... ......to
00106d 74 6f 6d 6d 79 00 00  00 00 00 00 00 00 00 00   mtommy.. ........
002000 00 00 00 00 00 00 00  00 00 00 00 49 6e 20 4c   ........ ....In L
00306f 72 00                                           or...... ........

Server -> Client: 0x25, 21 bytes
000025 40 01 5f 82 0f 8d 00  ea 5f 00 45 00 6e 00 40   %@._.... ._.E.n.@
001001 5f 6c 00 00                                     ._l..... ........

Server -> Client: 0x11, 91 bytes
000011 00 5b 00 00 00 02 74  6f 6d 74 6f 6d 6d 79 00   ..[....t omtommy.
001000 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
002000 00 00 00 00 00 82 00  82 00 05 00 00 82 00 82   ........ ........
003000 82 00 82 00 82 00 82  00 82 00 00 00 00 00 00   ........ ........
004000 18 01 ef 01 00 e1 00  00 00 00 00 00 00 00 00   ........ ........
005000 00 00 00 01 00 06 00  00 00 00                  ........ ........

Server -> Client: 0x25, 21 bytes
000025 40 01 5f 81 0f 8c 00  ea 5f 00 8a 00 80 00 40   %@._.... ._.....@
001001 5f 6c 00 00                                     ._l..... ........

Server -> Client: 0x11, 91 bytes
000011 00 5b 00 00 00 02 74  6f 6d 74 6f 6d 6d 79 00   ..[....t omtommy.
001000 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
002000 00 00 00 00 00 82 00  82 00 05 00 00 82 00 82   ........ ........
003000 82 00 82 00 82 00 82  00 82 00 00 00 00 00 00   ........ ........
004000 18 01 ef 01 00 e1 00  00 00 00 00 00 00 00 00   ........ ........
005000 00 00 00 01 00 06 00  00 00 00                  ........ ........

Server -> Client: 0xA2, 9 bytes
0000a2 00 00 00 02 00 82 00  7e                        ........ ~.......

Server -> Client: 0x3A, 11 bytes
00003a 00 0b ff 00 19 05 14  05 14 00                  :....... ........

Server -> Client: 0x6C, 19 bytes
00006c 00 00 00 00 06 02 00  00 00 00 00 00 00 00 00   l....... ........
001000 00 00                                           ........ ........

Client -> Server: 0x6C, 19 bytes
00006c 00 00 00 00 06 02 00  00 00 02 15 da 04 f5 00   l....... ........
001000 01 90                                           ........ ........

Server -> Client: 0x4F, 2 bytes
00004f 00                                              O....... ........

Server -> Client: 0x70, 28 bytes
000070 03 00 00 00 02 00 00  00 00 38 4e 15 da 04 f5   p....... ..8N....
001000 00 00 00 00 00 0a 0a  00 00 00 00               ........ ........

Client -> Server: 0xBF, 6 bytes
0000bf 00 06 00 24 30                                  ....$0.. ........

Client -> Server: 0xAD, 30 bytes
0000ad 00 1e 00 00 34 00 03  49 54 41 00 00 2e 00 73   .....4.. ITA....s
001000 74 00 6f 00 70 00 6c  00 6f 00 67 00 00         .t.o.p.l .o.g....

Log closed at %sThu Sep 18 17:23:10 2014
This is the log using the previous pol-core rev, packet 0x6e is present:

Code: Select all

[09/18 19:02:34] Logfile opened.
Server -> Client: 0x1C, 65 bytes
00001c 00 41 01 01 01 01 01  01 00 03 b2 00 03 53 79   ..A..... ......Sy
001073 74 65 6d 00 00 00 00  00 00 00 00 00 00 00 00   stem.... ........
002000 00 00 00 00 00 00 00  00 00 00 00 49 2f 4f 20   ........ ....I/O 
00306c 6f 67 20 66 69 6c 65  20 6f 70 65 6e 65 64 2e   log file  opened.
004000                                                 ........ ........

Client -> Server: 0xBF, 6 bytes
0000bf 00 06 00 24 7c                                  ....$|.. ........

Client -> Server: 0x12, 6 bytes
000012 00 06 56 36 00                                  ...V6... ........

Server -> Client: 0x1C, 51 bytes
00001c 00 33 00 00 00 02 01  90 00 03 e8 00 03 74 6f   ..3..... ......to
00106d 74 6f 6d 6d 79 00 00  00 00 00 00 00 00 00 00   mtommy.. ........
002000 00 00 00 00 00 00 00  00 00 00 00 49 6e 20 4c   ........ ....In L
00306f 72 00                                           or...... ........

Server -> Client: 0x6E, 14 bytes
00006e 00 00 00 02 00 10 00  05 00 01 00 00 01         n....... ........

Server -> Client: 0x25, 21 bytes
000025 40 01 51 4a 0f 8d 00  c3 4a 00 75 00 7a 00 40   %@.QJ... .J.u.z.@
001001 51 34 00 00                                     .Q4..... ........

Server -> Client: 0x11, 91 bytes
000011 00 5b 00 00 00 02 74  6f 6d 74 6f 6d 6d 79 00   ..[....t omtommy.
001000 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
002000 00 00 00 00 00 82 00  82 00 05 00 00 82 00 82   ........ ........
003000 82 00 82 00 82 00 82  00 82 00 00 00 00 00 00   ........ ........
004000 18 01 ef 01 00 e1 00  00 00 00 00 00 00 00 00   ........ ........
005000 00 00 00 01 00 06 00  00 00 00                  ........ ........

Server -> Client: 0x25, 21 bytes
000025 40 01 51 49 0f 8c 00  c3 4c 00 37 00 5e 00 40   %@.QI... .L.7.^.@
001001 51 34 00 00                                     .Q4..... ........

Server -> Client: 0x11, 91 bytes
000011 00 5b 00 00 00 02 74  6f 6d 74 6f 6d 6d 79 00   ..[....t omtommy.
001000 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
002000 00 00 00 00 00 82 00  82 00 05 00 00 82 00 82   ........ ........
003000 82 00 82 00 82 00 82  00 82 00 00 00 00 00 00   ........ ........
004000 18 01 ef 01 00 e1 00  00 00 00 00 00 00 00 00   ........ ........
005000 00 00 00 01 00 06 00  00 00 00                  ........ ........

Server -> Client: 0xA2, 9 bytes
0000a2 00 00 00 02 00 82 00  7e                        ........ ~.......

Server -> Client: 0xA2, 9 bytes
0000a2 00 00 00 02 00 82 00  82                        ........ ........

Server -> Client: 0x1C, 62 bytes
00001c 00 3e 01 01 01 01 01  01 00 03 e8 00 03 53 79   ..>..... ......Sy
001073 74 65 6d 00 00 00 00  00 00 00 00 00 00 00 00   stem.... ........
002000 00 00 00 00 00 00 00  00 00 00 00 54 68 65 20   ........ ....The 
003073 70 65 6c 6c 20 66 69  7a 7a 6c 65 73 00         spell fi zzles...

Server -> Client: 0x70, 28 bytes
000070 03 00 00 00 02 00 00  00 00 37 35 15 da 04 f5   p....... ..75....
001000 00 00 00 00 00 07 07  00 00 00 00               ........ ........

Server -> Client: 0x54, 12 bytes
000054 01 00 5c 00 00 15 da  04 f5 00 00               T..\.... ........

Client -> Server: 0xAD, 30 bytes
0000ad 00 1e 00 00 34 00 03  49 54 41 00 00 2e 00 73   .....4.. ITA....s
001000 74 00 6f 00 70 00 6c  00 6f 00 67 00 00         .t.o.p.l .o.g....

Log closed at %sThu Sep 18 19:02:38 2014
Turley
POL Developer
Posts: 670
Joined: Sun Feb 05, 2006 4:45 am

Re: Characters&NPC Animations Core Bug?

Post by Turley »

Your client version is too new for the 0xe6 animation packet. With the latest changes it would receive the new animation packet 0xe2. But for this you need to fill the animxlate.cfg with new entries. Gives you also several other advantages. But I haven't yet documented it. You can read the code and write your own documentation or you wait till I come back from the beach in a few days ;)
tomtommy
New User
Posts: 27
Joined: Tue Oct 15, 2013 1:33 am

Re: Characters&NPC Animations Core Bug?

Post by tomtommy »

Turley wrote:Your client version is too new for the 0xe6 animation packet. With the latest changes it would receive the new animation packet 0xe2. But for this you need to fill the animxlate.cfg with new entries. Gives you also several other advantages. But I haven't yet documented it. You can read the code and write your own documentation or you wait till I come back from the beach in a few days ;)
Very thanks for your reply Turley, I'll try to fill the cfg file before your return :P
Locked