Page 1 of 1

Animation Edit Bug report and suggestion

Posted: Sun Jan 24, 2010 7:06 am
by soulsoul666
Hello Turley.. i will report some bugs found in anim edit

1)Uo fiddler converts many imagens to a wrong color... like this image
Image

2)when i try to add one image to an empty animation slot... the color of image is converted only to white tone
Image

My suggestions:
1)you can add an option to add MANY IMAGES at the same time to an animation... for example.. i must add 10 frames of animation to one slot... but with "add" options of anim edit i can only add one frame by one... an option to add many frames at the same time would be great =]

2)you can add an option to put all animations of the same slot at the same cordinate.... it would be GREAT...
for example: my walk animation at down position has 10 frames... and all frames at the same cordinate...but i must put all these 10 frames at the same cordinate one by one.... this is boring..

3)just look at image
Image
With UOanim arrow.. it is easier to view where you are going with animation.... because with uo fiddler arrow you dont have reference where you are going with image in X center... because the image will walk in this positions <<<< or >>>>> ... bahh i cant explain this ...


Ok.. this is my suggestions... sorry for my bad english... =].. cya

Re: Animation Edit Bug report and suggestion

Posted: Wed Jan 27, 2010 1:06 pm
by soulsoul666
Ok.. i worked on your code and made my own modification.. now the program can add many BMPS at the same time in animation edit

Just replace metod OnClickAdd in your original AnimationEdit.cs for this OnClickAdd Metod... Cya man =]

Code: Select all

                                private void OnClickAdd(object sender, EventArgs e)
        {
            if (FileType != 0)
            {
                using (OpenFileDialog dialog = new OpenFileDialog())
                {
                    dialog.Multiselect = true;
                    dialog.Title = "Choose image file to add";
                    dialog.CheckFileExists = true;
                    dialog.Filter = "image files (*.tiff;*.bmp)|*.tiff;*.bmp";
                    if (dialog.ShowDialog() == DialogResult.OK)
                    {
                        //my modification
                        //foreach (String file in dialog.FileNames)
                        //{
                              for(int w=0; w<dialog.FileNames.Length; w++)
                              {
                              Bitmap bmp = new Bitmap(dialog.FileNames[w]); // dialog.FileName replaced by dialog.FileNames[w]
                                if (dialog.FileName.Contains(".bmp"))
                                    bmp = Utils.ConvertBmp(bmp);
                                AnimIdx edit = Ultima.AnimationEdit.GetAnimation(FileType, CurrBody, CurrAction, CurrDir);
                                if (edit != null)
                                {
                                    edit.AddFrame(bmp);
                                    TreeNode node = GetNode(CurrBody);
                                    if (node != null)
                                    {
                                        node.ForeColor = Color.Black;
                                        node.Nodes[CurrAction].ForeColor = Color.Black;
                                    }
                                    ListViewItem item;
                                    int i = edit.Frames.Count - 1;
                                    item = new ListViewItem(i.ToString(), 0);
                                    item.Tag = i;
                                    listView1.Items.Add(item);
                                    int width = listView1.TileSize.Width - 5;
                                    if (bmp.Width > listView1.TileSize.Width)
                                        width = bmp.Width;
                                    int height = listView1.TileSize.Height - 5;
                                    if (bmp.Height > listView1.TileSize.Height)
                                        height = bmp.Height;

                                    listView1.TileSize = new Size(width + 5, height + 5);
                                    trackBar2.Maximum = i;
                                    listView1.Refresh();
                                    Options.ChangedUltimaClass["Animations"] = true;
                                }
                              }
                        //}    
                    }
                }
            }
        }

Re: Animation Edit Bug report and suggestion

Posted: Sat Feb 06, 2010 12:09 pm
by nibbio
I've add two small functions at Animation Edit and Compare Plugin

- Animation Edit can add multiple files
- Compare plugin can compare also texture, and has two functions: copy all diff to left, and copy only empty diff to left.

I can't find where is the animation edit bug :( maybe in Ultima DLL, when write the frame edit.

Re: Animation Edit Bug report and suggestion

Posted: Sun Feb 07, 2010 4:08 am
by Turley
Thx for the input guys.
Currently I have not much time, but its on top of my todo list :)

About the color import bug can you send me the importfiles?

Re: Animation Edit Bug report and suggestion

Posted: Wed Feb 17, 2010 3:27 am
by nibbio
This is one of the files that i can't add correctly with fiddler.

Fiddler makes it all black, maybe i do something wrong when i convert this bmp for 555 format...
0_0.rar
(2.02 KiB) Downloaded 338 times