Clothing becoming invisible

[OldnGrey]

I am fairly certain this is a core bug, probably introduced with pol097rc4 (as part of 096.7 bugfixes.)

I went to 097rc5 and players started to notice that their player vendors and henchmen started to get clothing becoming invisible.

eg Our player vendor has a verbal command 'name wear' and you target an item of clothing. They will put it on. However, anything that was already equipped anywhere on their equip layers goes invisible. Paperdoll reacts the same way if it's open. All I have to do it go offscreen and back again to see they are in fact wearing all the clothes.

I looked through the changes from rc3 to rc5 and nothing seems to apply except maybe a bug in the 096.7 change:

[OldnGrey]

Same bug as reported in:
http://forums.polserver.com/viewtopic.php?t=1809&highlight=

Reproducable on non britannia realm.

[Yukiko]

OnG this may be a rellated issue to the multi bug that I reported I think Maud put the core change in because of that bug though since they don't put a year in the dates in corechanges I can't be totally sure. Might be that this change created a new bug.

[OldnGrey]

Yukiko.
This core bug wasn't there in 097rc3 and first appeared in rc4 or rc5.
I doubt it was rc5 related because that was mainly the packethook memory leak fix release. (I never tried rc4)

That places it somewhere between April and August this year. So I think that it won't be directly related to your bug from last year.


On an npc you see this because only the last item equipped by the npc is visible.


I also have reports of players dropping items of clothing on their own player paperdolls and having them vanish. (this is more what Coltain mentioned in the other post I linked above). I can't reproduce this yet but the npc one is 100% reproducable.


Just to re-iterate the npc one:
realm: britannia_alt
core 097rc5
client: 4.0.3, 5.0.9.1
An npc responds to the 'wear' spoken command by offering a target cursor to select the item to equip. The item is equipped, but all previously equipped items become invisible. All items are still equipped but you need to move offscreen and back to see them all.
IncRevision(npc) and SetName(npc, npc.name) which usually tell the core to update the client do NOT work.

[Yukiko]

OnG I tried reproducing this bug. It definitely is there for me too but only when using the player vendor "wear" command. I used the .equip command and the player vendor did not lose his clothes. I haven't had time to research the scripts more but here is the code for the .equip command I have. Maybe it will be of help in deciphering what is happening.

[OldnGrey]

Interesting. Thanks for the comments. I knew it wasn't totally straightforward otherwise creating a clothed npc wouldn't work. You've helped me look a bit further.

Looking further into the code for vendors wearing an item, it appears all clothing is first stripped from the npc, then the new item equipped, then the rest are equipped. Thing is, they are equipped from the storage area which appear to be always created in britannia realm.

ie from:
inv_pb := find_or_create_item(storage, me.serial + " PB", 0xE7C);

So therefore the bug appears to be caused when an item is equipped from a different realm.



Here's the code that will show the problem:

[Yukiko]

The items do reappear if you leave the visible area of the NPC and go back though don't they? I can't see how this would be a realm dependant thing but then again I don't know how POL works internally either. Hopefully Maud will get a chance to check this out.

In the meantime maybe the "wear" function needs to be rewrtten to only remove any item already equipped on the layer that the targetted item will be equipped on. That way ya don't get a totally stripped NPC.

[OldnGrey]

I've got workarounds for npcs as posted already. I simply translate them to a spot in britannia and back again a few mS later.

But for players it's harder since a lot of players like to equip directly from special containers which are in britannia (like the bank) and I know of no way to make the item visible on a player without logging off and on again. Players on my shard have seen this happen, but I haven't been able to replicate it. That's why I posted the npc code to replicate the problem and not talked so much about players equipping. There is possibly a workaround for the players equipping, but because I haven't seen it, I can't work with it.

The bug is not so easy to define is it? Maybe it's the doubleclick to equip rather than drag on-cursor to paperdoll. More testing to be done.

[Yukiko]

Might need to look into the 'use' scripts for the equippables. I remember WoD was written to make D/Cing an item equip it. I gather you haven't tested the effect of the 'use' equip script versus the drag and drop equipping method. Maybe there's something different when a script equips an item versus the drag method although I can't see how.

[OldnGrey]

I've been asking the players. They all report dragging on the mouse pointer to equip from their bankbox is the problem.

Doubleclick (ie usescript) doesn't work in this instance because the scripts prevent you equipping if it's not in your backpack.


There's not a lot more I can do now. I'd love a core developer to look at this.

[coltain]

Simple test:

Player is in Ilshenar (for eg.)
Equip armor (dragging) from bankbox - armor equiped is invisible
Equip armor (dragging) from backpack - armor equiped is visible

i`ll try to change my equip scripts (when player is in other realm then britannia first move item to place in this realm and then equip)

[OldnGrey]

You will find you can't do anything with the item in the 'equipscript' entry. It's supposed to return 1 or 0. It's a nice way to generate an exception if you try to move it to their backpack first.

I am currently doing a total hack workaround in the equipscript - ie stop them equipping from a different realm. I'd much rather the core fix though

Since this script is run also during shard startup you only want it run when the player is online and dragging the item. eg:

[Yukiko]

OnG I tried to work around this with the following code for equip.src but POL throws me an exception and gave me a core dump, which is 0 bytes in size.

[ncrsn]

[Yukiko]

That's a good question.

Does using the POL function EquipItem() call the item's equip script?

Since the modified equip script is calling an internal POL function I didn't think it was but you might be right.

The problem mentioned by OnG seems to be that items equipped (dragged onto a character) from special containers, which are "kept" in the britannia realm, don't properly display on a mobile when that mobile is in any other realm other than britannia. So what I wanted to do was unequip the item, move it to the realm the character is in and re-equip it from that realm, hopefully fast enough that it wouldn't be visible.

Anyway, maybe someone can let me know if I am causing an infinite loop there. Like I said I thought using the EquipItem() function would bypass the equip script but who knows.