Guild package, please read!

[MontuZ]

[OldnGrey]

Dammit man, I'm not criticizing your code! I am just scared of that old gump stuff. And I was thrilled to see the first update in the distro code since May 12!

Oh, by the way, are you dead sure about the uopacket.cfg? Since 0xD7 is a generic packet, I am thinking of putting that initial code into pkg\packethooks.

I got nothing when pressing the Guild button. I can't see how it matches the 0xD7 documentation. Just to prove it all, I tried this which appears to work (for guild button at least):

[MontuZ]

I might try to use gumps that way here in a little.

*Fixed the << >> thingy, missed that one. I'll commit changes when I do more work on it.

And I'll change the way the packet's handled, I knew it would soon grow into an issue.

[OldnGrey]

Is it normal for a change of faction to remove ALL allies and enemies or leaving enemies if it's still a different faction? I am writing this bit now but don't know the convention.

What sort of voting for new leader system are you suggesting? Would you have it activate at "member" logon or use Austin's mail system? I've been putting lots of things through the mail system lately (and a 30 day mail prune too keeps it tidy for all those prople who never bother to read them).

It's a lot of fun doing guilds! A pity my code isn't up to distro standard. However, I am happy to send you the changes I've done in case it helps you at all.

[OldnGrey]

Some assistance from anyone who knows the conventions please.....

What is the definition of an opposing faction?

The way the distro is written:
If you are order, an opposing faction is chaos but not neutral
If you are chaos, an opposing faction is order but not neutral
However if you are neutral, an opposing faction is chaos and order.

That means an order can request alliance with neutral, but a neutral cannot request alliance with order.

Since I have no clue about the convention, I'd only be guessing.


* I have added an email notification when you remove alliances or war or when changing factions breaks relationship, or when you demote, promote or kick a member.
* Fixed a bug where you could promote or demote members of different guild.
* Fixed a bug where you could promote a guild member to Guild Master.

[MontuZ]

Thanks for bringing that up OldnGrey. I'll fix the opposing factions thing when I get a chance too.

I meant to have Neutral an opposing faction to Chaos/Order and Chaos/Order shouldn't be able to request an alliance with them. I don't know what I was thinking when I wrote it, lol.

[OldnGrey]

Sorry, my fault. I've been playing with factions too much. Cross that off your list.

As far as actual bugs go, only 2 so far.
* you can promote/demote/remove members from a different guild
* you can promote someone to be another GuildMaster.
Both easily fixed.

I seem to have gotten factions, ondelete and monthly cleanups written without much drama and mailouts to effected guilds with the SendEmail function.
Also I've moved the hook to its own package under packethooks because it's more generic than just guilds.

Now for the one I've been dreading: the "In Vote" bit at logon.

By the way, events.inc seems to be redundant.

What has been of most interest in this package is the fact that your style is very easy to follow even if you do use Austin's settings functions.

All my comments here are not so much for you to use what I've written, it's more to get your interest fired up again

[OldnGrey]

I've finished the player guilds package, including autopruning of members and guilds, voting, factions, changing titles etc. It makes extensive use of logging and the Distro's email package.

But I can't post it in the scripts forum because it's not allowing any attachments.

If you are interested, let me know. Feel free to get it and tear it apart - it might help you finish the real distro package a bit faster.

Mine is not a drop in for the distro because I use my own logging (096 distro actually) and use the title_guild for other things too, but it's pretty much compatible.

[ncrsn]

Can't wait.

We are currently using somewhat tuned guild package from D95 and it's quite... Outdated. I have started scripting a new version several times but never really got it done, so I'm really looking forward for this.

[OldnGrey]

If you mean Bishop's guildstone package, then I have been using that too.

Part of the autocleanup is to look for guilds using the guildstone system and remove members and guilds. (My itemdesc.cfg contains blanks for the old guildstone and guilddeed so you can disable the old package entirely.)

For a long time I was toying with the Guildstone package to update it to 097, but it had 2 hurdles - it was written in the first version of GFGumps, plus I had already decided to use as much of the 097 distro as possible. So my challenge was to take MontuZ's guild system and finish it. I hope MontuZ does finish it and I'd be honoured if my version helped in any way.

[ncrsn]