 |
 |
|
|
| Author |
Message |
Bracco
Joined: 28 Dec 2006
Posts: 80
|
 Posted: Sat Mar 17, 2007 5:39 am Post subject: Packethook leak |
 |
|
there is a memory leak in packethooks, unfortunately it isn't related to what code it's inside them, it just happens when a packet is sent or received and there's a packethook for it.
it appears to affect both receivefunction and sendfunction
core version: 097 2007-01-04 RC2 Coregina
platform: windows
i did some testing, starting with a very simple and empty packethook:
uopacket.cfg:
| Code: | Packet 0x11
{
Length variable
SendFunction stat:status
} |
stat.src:
| Code: |
exported function status(who, byref packet)
return 0;
endfunction
|
to test it i ran a injection macro that continuously equips and unequips armor, so the status packet is being sent continuously because of the armor value change.
there was only 1 player online, me, and i am sure my server alone doesn't grow in memory usage: i let it run for hours without players without getting even a mb increase
these are the results: (i disabled pagefile to make task manager more readable, with pagefile active windows continuously swaps something from physical ram to pagefile)
beginning:
after 10 minutes:
as you can see, the ram usage grew about 8 MB, but that's with only 1 player doing this and for only 10 minutes. being a packethook leak, and given the fact that most shards will probably have more than 1 packethook, you can imagine how bad could the leak turn out with many players.
then i tried adding some code to the hook, and this is the result:
beginning:
after 10 minutes:
as you can see the memory usage is pratically identical to the one without any code inside the hook
i then disabled the hook and ran the same test:
beginning:
after 10 minutes:
without the hook there's no leak, just a very slight variation probably due to some script running in background
that's as much info as i can, probably this is the leak that people (including me) complained for a while, hope it's easyly fixable so we could hope to see the fix in the next release  |
|
 |
|
|
|
|
|
|
|
|
|
